Files
navegator_dashboard/CMakeLists.txt
T
egutierrez df8c0864f6 fix(layouts): persist panel visibility por layout + e2e tests
Bug: al pulsar un layout guardado el dock layout se aplicaba pero los paneles
ocultos quedaban con dock node vacio. Causa: el INI de ImGui solo guarda
posicion/dock; la visibilidad (`show_*` bools) es estado puro de la app y no
se restauraba al apply.

Fix:
- Tomar control del menu Layouts (cfg.auto_layouts=false). Abrir LayoutStorage
  propio + segunda tabla `panel_visibility` en la misma layouts.db (CREATE
  TABLE IF NOT EXISTS, aditivo, no rompe layouts existentes).
- on_save: capture_panel_state() serializa show_* a JSON y se persiste junto
  al INI bajo el mismo nombre.
- on_apply: marca pending INI + carga state JSON pendiente.
- on_reset: clear INI + open_all_panels (reabre Browsers/Tabs/TabDetail/Network).
- on_delete: borra fila imgui_layouts + sidecar.
- drain_layout_pending() (llamado desde render() cada frame) aplica
  LoadIniSettingsFromMemory + apply_panel_state. Fallback: si layout no tiene
  sidecar (back-compat con layouts antiguos) abre todos los paneles.

Refactor:
- main.cpp: render() ya no es static — necesario para que el test harness
  reuse la misma funcion. int main() guardado tras `#ifndef FN_TEST_BUILD`.
- show_* bools y k_panels movidos al namespace navegator (extern para tests).
- dashboard_state.h: nuevo header expone show_*, setup_layouts(),
  teardown_layouts(), capture/apply_panel_state, open_all_panels y los
  hooks layout_save/apply/delete/reset + drain_layout_pending para tests.

Tests (Dear ImGui Test Engine, opt-in via -DFN_BUILD_TESTS=ON):
  tests/navegator_dashboard_tests.cpp — 6 tests, todos pasan:
  1. panel_state_roundtrip            — capture/apply JSON simetrico.
  2. open_all_panels_marks_main_visible.
  3. save_hide_apply_restores_visibility (FIX BUG).
  4. two_layouts_swap_visibility       — minimal vs full.
  5. reset_opens_all_main_panels.
  6. legacy_layout_fallback_opens_all  — sin sidecar.

Build/run:
  cmake -B cpp/build/windows_tests -S cpp \
        -DCMAKE_TOOLCHAIN_FILE=$(pwd)/cpp/toolchains/mingw-w64.cmake \
        -DFN_BUILD_TESTS=ON
  cmake --build cpp/build/windows_tests --target navegator_dashboard_tests
  Deploy + run via cmd.exe -> 6/6 tests passed.

CMakeLists.txt: añade target navegator_dashboard_tests bajo if(FN_BUILD_TESTS),
linka mismas libs que prod + define FN_TEST_BUILD para que main.cpp no
duplique main(). WIN32_EXECUTABLE FALSE para ver stdout en consola.

Issue 0003 (sub-issue del roadmap navegator_dashboard 0001).

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
2026-05-10 13:09:50 +02:00

59 lines
1.8 KiB
CMake

# navegator_dashboard — Windows-only por diseño.
# Linux: skip silenciosamente para que cpp/build/ no falle.
if(NOT WIN32)
message(STATUS "navegator_dashboard: skipping (Windows-only).")
return()
endif()
add_imgui_app(navegator_dashboard
main.cpp
chrome_scanner.cpp
chrome_launcher.cpp
local_api.cpp
panels.cpp
agent.cpp
cdp_http.cpp
cdp_ws.cpp
network_state.cpp
session_state.cpp
)
target_include_directories(navegator_dashboard PRIVATE ${CMAKE_CURRENT_SOURCE_DIR})
# imgui_node_editor expone su propio include dir (vendor/imgui-node-editor)
# que contiene crude_json.{h,cpp}. Lo linkamos solo para reusar crude_json
# como parser JSON: sin dependencia nueva, sin codigo de node-editor en runtime.
target_link_libraries(navegator_dashboard PRIVATE
ws2_32
imgui_node_editor
)
set_target_properties(navegator_dashboard PROPERTIES WIN32_EXECUTABLE TRUE)
# --- E2E tests (opt-in via -DFN_BUILD_TESTS=ON) ---
if(FN_BUILD_TESTS)
add_imgui_app(navegator_dashboard_tests
main.cpp
chrome_scanner.cpp
chrome_launcher.cpp
local_api.cpp
panels.cpp
agent.cpp
cdp_http.cpp
cdp_ws.cpp
network_state.cpp
session_state.cpp
tests/navegator_dashboard_tests.cpp
)
target_include_directories(navegator_dashboard_tests PRIVATE ${CMAKE_CURRENT_SOURCE_DIR})
target_link_libraries(navegator_dashboard_tests PRIVATE
ws2_32
imgui_node_editor
)
# Excluye int main() de main.cpp; el harness define su propio main().
target_compile_definitions(navegator_dashboard_tests PRIVATE FN_TEST_BUILD)
# Subsistema consola (no WIN32_EXECUTABLE) para ver output de los tests.
set_target_properties(navegator_dashboard_tests PROPERTIES WIN32_EXECUTABLE FALSE)
endif()